Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore using PHP Traits for certain methods #40

Open
jjgrainger opened this issue Oct 28, 2018 · 0 comments
Open

Explore using PHP Traits for certain methods #40

jjgrainger opened this issue Oct 28, 2018 · 0 comments

Comments

@jjgrainger
Copy link
Owner

Between PostType and Taxonomy classes, there is repeated code around the names, labels, options, and column methods. Consider using PHP traits to reduce duplicate code and make it easier to maintain, while not over engineering the project.

Traits could as be used for cases such as pluralizing names with regards to PR #22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jjgrainger