Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drawAsInfinite #5

Open
aknapp opened this issue Mar 14, 2012 · 13 comments
Open

drawAsInfinite #5

aknapp opened this issue Mar 14, 2012 · 13 comments

Comments

@aknapp
Copy link

aknapp commented Mar 14, 2012

Any chance we can get support for graphite's 'drawAsInfinite()' function? Useful for tracking rollouts and whatnot.

@jondot
Copy link
Owner

jondot commented Mar 14, 2012

I'll check it out!

@jondot
Copy link
Owner

jondot commented Mar 28, 2012

Looks completely possible. I'll try implementing it over the weekend.

@roelven
Copy link

roelven commented May 23, 2012

Any news on this? Just found out it doesn't render infinites properly

@jondot
Copy link
Owner

jondot commented May 23, 2012

Hi Roel,
Yes, I apologize for being under the radar lately. I hope to work on this, additional fixes, and D3 upgrade all in one, as soon as possible!

@roelven
Copy link

roelven commented May 23, 2012

That'd be great.

We've found Graphene very useful so far, I'd love to show you our
implementation once we've matured it a bit more.

Awaiting your update, cheers!

On Wed, May 23, 2012 at 5:46 PM, Dotan J. Nahum <
[email protected]

wrote:

Hi Roel,
Yes, I apologize for being under the radar lately. I hope to work on this,
additional fixes, and D3 upgrade all in one, as soon as possible!


Reply to this email directly or view it on GitHub:
#5 (comment)

Roel van der Ven
Product manager Web

Mail: [email protected]
Skype: roelvanderven
Cell: +49 1577 5302629
http://soundcloud.com/roelven
http://twitter.com/roelven
Rosenthalerstraße 13, 10119 Berlin, Germany

What is SoundCloud?
http://soundcloud.com/tour

We're hiring!
http://soundcloud.com/jobs

@jondot
Copy link
Owner

jondot commented May 23, 2012

I'm very excited to hear that, thanks! :)

@jondot
Copy link
Owner

jondot commented May 26, 2012

Hey guys,
Here's a first stab at implementing this
https://github.com/jondot/graphene/tree/draw_as_infinite

To use it, just pick up graphene.min.js and drop into your current folder structure.
Then for a given TimeSeries,

"Topics": {
      source: "http://localhost:4567/",
      TimeSeries: {
         parent: '#g1-3',
         as_infinite: [0]
      }
 }

assuming the as-infinite series is the first one (index 0).

There are a couple inconveniences that I'm aware of (and would appreciate feedback on):

  1. You need to refer to your as-infinite series by index (how bad is this?), because unlike Graphite, we're not parsing the actual request URL.
  2. The processing is on the data-level (and not UI). Once a series is marked as_infinite, we're transforming the data points according to the drawAsInfinite rules. Then the UI draws it as usual, so it looks like a graph with very sharp spikes (instead of a straight line). In order to draw it as a line, we'll need to introduce a new drawing layer for adornments, because a line isn't really a time-series graph.

In anycase, let me know if this works sufficiently well for you, and i'll merge it.

@roelven
Copy link

roelven commented Jun 7, 2012

Hey Dotan,

Awesome, thanks for this!
I've just implemented your new build, looks good but it seems like it's rendering the initial resource twice, like here:

DrawAsInifinite

Is that a known side-effect?

Cheers

@roelven
Copy link

roelven commented Jun 7, 2012

Just noted the update messes with the y scale as well. The curve is looking a lot different in the original graphite graph, maybe that's related to the double line?

@jondot
Copy link
Owner

jondot commented Jun 7, 2012

Will check when in front of a desktop, thanks
On Jun 7, 2012 7:21 PM, "Roel van der Ven" <
[email protected]>
wrote:

Just noted the update messes with the y scale as well. The curve is
looking a lot different in the original graphite graph, maybe that's
related to the double line?


Reply to this email directly or view it on GitHub:
#5 (comment)

@jondot
Copy link
Owner

jondot commented Jun 7, 2012

Hi Roel,
Both of the issues don't initially make sense, it doesn't happen before this update right?

just to let you in on the detail this is the only update: 77d9f79#L1L299

It means that for the series index marked as as_infinite we'll pick the max value (of all the included series) and render that on/off according to the values of the as_infinite series.
the max of all series will serve us as 'infinite'.

However I do want to analyze this behavior i'm seeing in the snapshot -- if not much trouble is it possible for you to dump the JSON array to a Gist or such (coming from the ajax request) ?

thanks

@Jell
Copy link
Contributor

Jell commented Sep 14, 2012

I would also be interested in this feature.

On a side note, I made a pull request that should solve the rendering issue encountered here.

@jondot
Copy link
Owner

jondot commented Oct 12, 2012

thanks @Jell !, I pulled the change in. Now I'm wondering if draw-as-infinite is good enough as implemented here: 77d9f79#L1L299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants