Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize tests resolves #76 #229

Closed
wants to merge 5 commits into from
Closed

Localize tests resolves #76 #229

wants to merge 5 commits into from

Conversation

brandonsimpson21
Copy link

localizes finds_all_inner, finds_sub_elements, window_size_inner, window_position_inner, and window_rect_inner tests.

@brandonsimpson21 brandonsimpson21 changed the title Localize tests Localize tests resolves #76 Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #229 (83753ad) into main (9d4d31c) will increase coverage by 1.94%.
The diff coverage is n/a.

❗ Current head 83753ad differs from pull request most recent head cdce0db. Consider uploading reports for the commit cdce0db to get more accurate results

Additional details and impacted files

see 2 files with indirect coverage changes

@jonhoo
Copy link
Owner

jonhoo commented Aug 25, 2023

Thanks for taking this on! I'm going to semi-randomly go with #228, partially because it came in slightly earlier, and partially because they've also trimmed down the HTML to not actually hold the true Wikipedia HTML (which we don't really need for tests).

@jonhoo jonhoo closed this Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants