diff --git a/src/client.rs b/src/client.rs index 62f67f2..8e4f452 100644 --- a/src/client.rs +++ b/src/client.rs @@ -60,7 +60,6 @@ impl Client { /// should generally be one that supports HTTPS, as that is commonly required by WebDriver /// implementations. /// - /// Calls `with_capabilities_and_connector` with an empty capabilities list. pub(crate) async fn new_with_connector( webdriver: &str, connector: C, @@ -68,12 +67,25 @@ impl Client { where C: connect::Connect + Unpin + 'static + Clone + Send + Sync, { - Self::with_capabilities_and_connector( - webdriver, - &webdriver::capabilities::Capabilities::new(), - connector, - ) - .await + let (client, wdb) = Session::create_client_and_parse_url(webdriver, connector).await?; + Session::setup_session(client, wdb, None).await + } + + /// Reconnect to a previously established WebDriver session using its ID. + /// + /// Ideal for resuming operations without losing session data after a disconnect + /// or process restart, ensuring that the session can be reused without creating a new one. + /// + pub async fn with_existing_session( + webdriver: &str, + session_id: &str, + connector: C, + ) -> Result + where + C: connect::Connect + Unpin + 'static + Clone + Send + Sync, + { + let (client, wdb) = Session::create_client_and_parse_url(webdriver, connector).await?; + Session::setup_session(client, wdb, Some(session_id)).await } /// Connect to the WebDriver host running the given address. diff --git a/src/session.rs b/src/session.rs index 4af1b7e..6111b7a 100644 --- a/src/session.rs +++ b/src/session.rs @@ -535,6 +535,24 @@ impl Session where C: connect::Connect + Unpin + 'static + Clone + Send + Sync, { + fn new( + rx: mpsc::UnboundedReceiver, + client: hyper_util::client::legacy::Client>, + wdb_url: url::Url, + session_id: Option>, + ) -> Self { + Session { + ongoing: Ongoing::None, + rx, + client, + wdb: wdb_url, + session: session_id.map(Into::into), + is_legacy: false, + ua: None, + persist: false, + } + } + fn shutdown(&mut self, ack: Option) { // session was not created if self.session.is_none() { @@ -607,40 +625,58 @@ where } } - pub(crate) async fn with_capabilities_and_connector( + pub(crate) async fn create_client_and_parse_url( webdriver: &str, - cap: &webdriver::capabilities::Capabilities, connector: C, - ) -> Result { + ) -> Result< + ( + hyper_util::client::legacy::Client>, + url::Url, + ), + error::NewSessionError, + > { // Where is the WebDriver server? - let wdb = webdriver.parse::(); - let wdb = wdb.map_err(error::NewSessionError::BadWebdriverUrl)?; + let wdb = webdriver + .parse::() + .map_err(error::NewSessionError::BadWebdriverUrl)?; + // We want a tls-enabled client let client = hyper_util::client::legacy::Client::builder(TokioExecutor::new()) .build::<_, BoxBody>(connector); - let mut cap = cap.to_owned(); + Ok((client, wdb)) + } + + pub(crate) async fn setup_session( + client: hyper_util::client::legacy::Client>, + wdb: url::Url, + session_id: Option<&str>, + ) -> Result { // We're going to need a channel for sending requests to the WebDriver host let (tx, rx) = mpsc::unbounded_channel(); - // Set up our WebDriver session. - tokio::spawn(Session { + tokio::spawn(Session::new( rx, - ongoing: Ongoing::None, client, wdb, - session: None, - is_legacy: false, - ua: None, - persist: false, - }); + session_id.map(|id| id.to_string()), + )); // now that the session is running, let's do the handshake - let client = Client { - tx: tx.clone(), + Ok(Client { + tx, is_legacy: false, new_session_response: None, - }; + }) + } + + pub(crate) async fn with_capabilities_and_connector( + webdriver: &str, + cap: &webdriver::capabilities::Capabilities, + connector: C, + ) -> Result { + let (client, wdb) = Self::create_client_and_parse_url(webdriver, connector).await?; + let mut cap = cap.to_owned(); // Create a new session for this client // https://www.w3.org/TR/webdriver/#dfn-new-session @@ -659,6 +695,8 @@ where .insert("w3c".to_string(), Json::from(true)); } + let mut client = Self::setup_session(client, wdb, None).await?; + let session_config = webdriver::capabilities::SpecNewSessionParameters { alwaysMatch: cap.clone(), firstMatch: vec![webdriver::capabilities::Capabilities::new()], @@ -670,11 +708,11 @@ where .map(Self::map_handshake_response) .await { - Ok(new_session_response) => Ok(Client { - tx, - is_legacy: false, - new_session_response: Some(wd::NewSessionResponse::from_wd(new_session_response)), - }), + Ok(new_session_response) => { + client.new_session_response = + Some(wd::NewSessionResponse::from_wd(new_session_response)); + Ok(client) + } Err(error::NewSessionError::NotW3C(json)) => { // maybe try legacy mode? let mut legacy = false; @@ -717,11 +755,8 @@ where .map(Self::map_handshake_response) .await?; - Ok(Client { - tx, - is_legacy: true, - new_session_response: None, - }) + client.is_legacy = true; + Ok(client) } Err(e) => Err(e), }