Merge pull request #232 from ChaseCares/remove_wikipedia_links #446
GitHub Actions / clippy
succeeded
Aug 27, 2023 in 1s
clippy
4 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 4 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.72.0 (5680fa18f 2023-08-23)
- cargo 1.72.0 (103a7ff2e 2023-08-15)
- clippy 0.1.72 (5680fa1 2023-08-23)
Annotations
Check warning on line 212 in src/key.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/key.rs:212:25
|
212 | String::new() + &self + rhs
| ^^^^^ help: change this to: `self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 212 in src/key.rs
github-actions / clippy
taken reference of right operand
warning: taken reference of right operand
--> src/key.rs:212:9
|
212 | String::new() + &self + rhs
| ^^^^^^^^^^^^^^^^-----
| |
| help: use the right value directly: `self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
= note: `#[warn(clippy::op_ref)]` on by default
Check warning on line 810 in src/session.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> src/session.rs:810:55
|
810 | let body = match serde_json::from_str(&*body)? {
| ^^^^^^ help: try this: `&body`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `#[warn(clippy::explicit_auto_deref)]` on by default
Check warning on line 745 in src/session.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> src/session.rs:741:70
|
741 | base64::engine::general_purpose::STANDARD.encode(&format!(
| ______________________________________________________________________^
742 | | "{}:{}",
743 | | url.username(),
744 | | url.password().unwrap_or("")
745 | | ))
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
help: change this to
|
741 ~ base64::engine::general_purpose::STANDARD.encode(format!(
742 + "{}:{}",
743 + url.username(),
744 + url.password().unwrap_or("")
745 ~ ))
|
Loading