Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pin the upper bound of Cython dependency #1088

Closed
wants to merge 1 commit into from
Closed

Don't pin the upper bound of Cython dependency #1088

wants to merge 1 commit into from

Conversation

befeleme
Copy link

Closes #1087

@CLAassistant
Copy link

CLAassistant commented Nov 14, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

jopohl
jopohl requested changes Nov 14, 2023
View reviewed changes
Copy link
Owner

@jopohl jopohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove the pin from requirements.txt.

@befeleme
Copy link
Author

Fixed in the amended commit.

@jopohl
Copy link
Owner

jopohl commented Nov 15, 2023

Thanks, CI is now failing though as reported #1063.

@jopohl
Copy link
Owner

jopohl commented Jan 21, 2024

Fixed via #1099

@jopohl jopohl closed this Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jopohl jopohl jopohl requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Cython 3.0+
3 participants
@befeleme @CLAassistant @jopohl