-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exporting <package-name>Config.cmake files with no targets. #398
Comments
Do not call INSTALL(EXPORT ...) when having no targets but generates the Config.cmake file.
Do not call INSTALL(EXPORT ...) when having no targets but generates the Config.cmake file.
Hi @olivier-stasse, Where do you have this issue ? |
talos_data when gazebo is not detected. |
Can you please open an issue on talos-data, before working further on that topic ? This looks like stack-of-tasks/talos-data#2 to me. |
I respectfully disagree. jrl-cmakemodules should be able to handle package with no target. |
But of course this is a personal opinion that should be discussed openly and I will go towards the community decision. |
I agree, jrl-cmakemodules should be able to handle package with no target. But I would like to understand the issue you are trying to solve on talos-data. That was the topic I was speaking of, sorry this was not clear. |
…o targets but generates the Config.cmake file." This reverts commit 5d602f8.
…o targets but generates the Config.cmake file." This reverts commit 5d602f8.
Fixed by PR #408 |
Do not call INSTALL(EXPORT ...) when having no targets but generates the Config.cmake file.
…en having no targets but generates the Config.cmake file." This reverts commit 5d602f8.
When having pure data package, typically robot_description kind of packages, the Config.cmake files are very handy.
However they do not have targets. In the current writing of the SETUP_PROJECT_PACKAGE_FINALIZE macro the INSTALL( export ) calls fails because they are no targets to export.
IMHO the correct behavior is to not call this install when there is no target.
The text was updated successfully, but these errors were encountered: