Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional 3D markers in the GUI #348

Open
mmurooka opened this issue Feb 13, 2023 · 4 comments
Open

Additional 3D markers in the GUI #348

mmurooka opened this issue Feb 13, 2023 · 4 comments
Labels
enhancement New feature or request GUI Related to GUI features

Comments

@mmurooka
Copy link
Member

This is not an issue, but a feature request for the future.

It would be nice to have more types of 3D markers in the GUI. For example, the following types supported by ROS visualization_msgs/Marker messages are not available in mc_rtc.

  • boxes (CUBE in visualization_msgs/Marker)
  • spheres and ellipsoids (SPHERE in visualization_msgs/Marker)
  • lines (LINE_LIST in visualization_msgs/Marker. Although LINE_STRIP can be handled by mc_rtc::gui::Trajectory, LINE_LIST is still useful.)

Supporting these features reduces the motivation for users to do things away from the mc_rtc concept, such as publishing their own ROS topics for the GUI as in https://github.com/isri-aist/Motion6DoF/pull/5#issuecomment-1418423577.

@gergondet
Copy link
Member

boxes (CUBE in visualization_msgs/Marker)
spheres and ellipsoids (SPHERE in visualization_msgs/Marker)

These two can (mostly) be handled via Visual although:

  • this is not part of this documentation
  • creating Visual objects is a little more involved than they should be
  • we cannot display ellipsoid via Sphere (since the Visual element is from the definition of URDF visual elements) but we can via Superellipsoid although I think the client does not handle them

Note: mc_rtc's Visual also handles cylinders and meshes

I think we can add a nice helper to simplify usage here (and improve the docs)

To handle LINE_LIST we have to introduce a new type in mc_rtc GUI.

@mmurooka
Copy link
Member Author

mmurooka commented Mar 1, 2023

I will close this as it was handled by #299. Thank you.

@mmurooka mmurooka closed this as completed Mar 1, 2023
@gergondet
Copy link
Member

@mmurooka how about LINE_LIST-like functionality?

@mmurooka
Copy link
Member Author

mmurooka commented Mar 2, 2023

Oh, yes. It is desirable to have LINE_LIST as well. (At least Motion6DoF also used LINE_LIST.) I'll reopen the issue.

@mmurooka mmurooka reopened this Mar 2, 2023
@gergondet gergondet added enhancement New feature or request GUI Related to GUI features labels Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GUI Related to GUI features
Projects
None yet
Development

No branches or pull requests

2 participants