Undo/redo does not scroll to selection

[krassowski]

Description

This is one of the most frustrating things for me when using JupyterLab and it prevents me from working productively with larger files - see jupyterlab/jupyterlab#15102

Reproduce

See jupyterlab/jupyterlab#15102

Expected behavior

Editor scrolls on undo/redo if the new selection is outside of the viewport.

Context

This was just fixed in y-codemirror.next: yjs/y-codemirror.next#34 but jupyter_ydoc does not use that and has its own integration of undo manager.

[krassowski]

It looks like we need something like this._undoManager.on('stack-item-popped', this._onStackItemPopped). For now I would propose to add it for text documents as in notebooks the behaviour is more complex.

Then, I wonder how is selection set currently if _onStackItemPopped is not implemented?

[krassowski]

This is one of the most frustrating things for me when using JupyterLab and it prevents me from working productively with larger files

Well, I'm not alone: https://stackoverflow.com/questions/78818736/follow-changes-with-the-mouse-cursor-when-pressing-ctrl-z-z-undo-redo-in-jup

[krassowski]

I do not have rights to tag issues here, but if I could I would tag it with help wanted Extra attention is needed