Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling /auth-sign-out #122

Open
ryanlovett opened this issue Jan 15, 2022 · 2 comments
Open

Handling /auth-sign-out #122

ryanlovett opened this issue Jan 15, 2022 · 2 comments
Labels

Comments

@ryanlovett
Copy link
Collaborator

When someone clicks the sign-out button, next to the rstudio quit button at the top right, the user receives a location in the response headers of /user/soandso/rstudio/auth-sign-out/auth-sign-in. Since the user gets logged out of rstudio, they receive a 401, and the body contains only Unauthorized.

If a user is on a hub with rstudio, I think the expected behavior of clicking this button is to initiate the hub sign-out process. So when the proxy sees /auth-sign-out/auth-sign-in in the response header, it should replace the value with /user/soandso/logout.

@ryanlovett ryanlovett added the bug label Jan 15, 2022
@ryanlovett
Copy link
Collaborator Author

@yuvipanda suggested on slack:

[let's] make it a configurable and default to base_url/logout when we know we are on a hub [...] so if people are running it without a hub that has functional logout (like mybinder!) they can do something else

@riazarbi
Copy link

riazarbi commented Jan 17, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants