-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final v3.0.0 release #354
Comments
What do you think about including #353? |
Is the timeline opt-in? Or can it be collapsed? Thinking it might take quite some space in the status bar, according to the screencast in the blog post: https://blog.jupyter.org/exploring-a-documents-timeline-in-jupyterlab-6084f96db263 If so, it could be useful to mention it in the docs: https://jupyterlab-realtime-collaboration.readthedocs.io/en/latest/ |
I think we should sync it with JupyterLab 4.3.0 final. I think we do not have to wait for #345 but it would be lovely to include it if we can. |
When do you see this happening? |
One week after RC gets published assuming no new blockers |
I just released jupyter-collaboration v3.0.0b4. |
But why does it need to be synced, since it works with JupyterLab 4.2.5? |
Ah, the dependency is the other way round. JupyterLab 4.3 requires the new collaboration packages to have lifted ydoc version pin, right? In that case I guess it does not need to wait :) |
Yes. I just tried jupyter-collaboration v3.0.0b4 with JupyterCAD, everything seems to work fine. |
So we are good to release final, right? |
There is still #353 that would be good to get in before v3. If it's merged after v3 that would be another breaking change. I'll rebase it. |
I just release v3.0.0beta8 which has #353, everything seems to work fine. |
One thing I noticed is that when creating a new notebook, no empty cell is created, even though jupyterlab/jupyterlab#16732 was not merged yet. It might be because of jupyter-server/jupyter_ydoc#266, but I thought this was not enough and the frontend added an empty cell if there was no cell. |
I confirm it's caused by jupyter-server/jupyter_ydoc#266. |
I think we should merge jupyterlab/jupyterlab#16732 and have jupyter-server/jupyter_ydoc#266 enabled when |
I'm planning to release v3 soon, if there are no objections. |
I reverted jupyter-server/jupyter_ydoc#266 in jupyter-server/jupyter_ydoc#280. |
Did you specify the correct version spec? https://github.com/jupyterlab/jupyter-collaboration/blob/main/RELEASE.md#version-specification |
Oh I was not aware of this, I just specified |
yeah it's also a good practice to make an |
OK, let's release v3.0.0 final next week. I just released v3.0.0rc0. |
Since #379 seems to target v3.1.0, should we release v3.0.0 now? |
Similar to this JupyterLab 4.3.0 (blocker) issue: jupyterlab/jupyterlab#16649 Are we fine to depend on an alpha release of
|
We could release |
Yes, but from the discussion in jupyter-server/jupyter_ydoc#281, there seems to be one more issue to be fixed in |
Ah yes I forgot. |
I just bumped jupyter-ydoc v3.0.0, and I am going to release jupyter-collaboration v3.0.0 final. |
It seems to me that we could release jupyter-collaboration v3.0.0. I installed v3.0.0b3 and it works fine with JupyterLab v4.2.5. Or should we make another pre-release that includes the timeline?
The text was updated successfully, but these errors were encountered: