Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: feat(router): mask keys in connector_account_details for merchant_connector_response in mca retrieve flow #5890

Merged
merged 1 commit into from
Sep 16, 2024
Merged

revert: feat(router): mask keys in connector_account_details for merchant_connector_response in mca retrieve flow #5890

merged 1 commit into from
Sep 16, 2024

Conversation

sai-harsha-vardhan
Copy link
Contributor

@sai-harsha-vardhan sai-harsha-vardhan commented Sep 16, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

revert mask keys in connector_account_details for merchant_connector_response in mca retrieve flow - #5848
This reverts commit 71b5202.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested Manually
MCA create & retrieve to see api keys are not masked
Sanity payments, captures & refunds

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@sai-harsha-vardhan sai-harsha-vardhan added A-core Area: Core flows C-refactor Category: Refactor labels Sep 16, 2024
@sai-harsha-vardhan sai-harsha-vardhan self-assigned this Sep 16, 2024
@sai-harsha-vardhan sai-harsha-vardhan requested a review from a team as a code owner September 16, 2024 08:20
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Sep 16, 2024 •
edited
Loading

Review changes with SemanticDiff.

Analyzed 2 of 2 files.

Filename Status
✔️ crates/router/src/types/transformers.rs Analyzed
✔️ crates/hyperswitch_domain_models/src/router_data.rs 0.72% smaller

@bernard-eugine bernard-eugine merged commit 3e463bc into hotfix-2024.09.13.0 Sep 16, 2024
20 of 25 checks passed
@bernard-eugine bernard-eugine deleted the revert-api-key-masking-mca branch September 16, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@jarnura jarnura jarnura approved these changes

Assignees

@sai-harsha-vardhan sai-harsha-vardhan

Labels
A-core Area: Core flows C-refactor Category: Refactor
Projects
None yet
Milestone
September 2024 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@sai-harsha-vardhan @jarnura @Narayanbhat166 @bernard-eugine