-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): payment links - add support for custom background image and layout in details section #6725
Open
kashif-m
wants to merge
13
commits into
main
Choose a base branch
from
6711-payment-links-background-image
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Files
|
…d visibility in payment links template
hyperswitch-bot
bot
added
the
M-api-contract-changes
Metadata: This PR involves API contract changes
label
Dec 5, 2024
kashif-m
force-pushed
the
6711-payment-links-background-image
branch
from
December 5, 2024 20:53
f091e02
to
e5119b6
Compare
hyperswitch-bot
bot
removed
the
M-api-contract-changes
Metadata: This PR involves API contract changes
label
Dec 5, 2024
2 tasks
kashif-m
changed the title
6711 payment links background image
feat(core): payment links - add support for custom background image and layout in details section
Dec 5, 2024
…age' into 6711-payment-links-background-image
hyperswitch-bot
bot
added
the
M-api-contract-changes
Metadata: This PR involves API contract changes
label
Dec 5, 2024
kashif-m
force-pushed
the
6711-payment-links-background-image
branch
2 times, most recently
from
December 6, 2024 07:24
f47b37f
to
2e235da
Compare
jarnura
approved these changes
Dec 10, 2024
cookieg13
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR introduces UI revamps to the payment links by including below changes - (described in #6711)
branding_visibility
in business profile's payment link configdetails_layout
andbackground_image
in both business profile and payments create APIAdditional Changes
Motivation and Context
Helps configure details section for payment links, and fixes a few existing bugs around logos.
How did you test it?
Overview
Things to test and verify -
Steps for testing
Details layout
details_layout
is at both profile level and at payments API level1. Default layout (layout1)
details_layout
)cURL
layout1
in business profile configcURL
details_layout
in business profilecURL
layout1
in the payments APIcURL
2. Layout 2
layout2
in business profile configcURL
details_layout
in business profilecURL
layout2
in the payments APIcURL
Branding visibility
1. Default visibility
cURL
2. Hidden visibility
branding_visibility
to true in business profile configcURL
cURL
Background image
1. Background images in business profile
cURL
cURL
2. Background images in payments API
cURL
Checklist
cargo +nightly fmt --all
cargo clippy