Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): [Cybersource] change commerce indicator for discover cards in apple pay #6728

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

Sakilmostak
Copy link
Contributor

@Sakilmostak Sakilmostak commented Dec 3, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

commerce indicator for discover card in applepay is changed since the payments are failing in production for cybersource

Note: This is hotifx against #6690

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested through postman:

  • Create an MCA for Cybersource:
  • Create a Payment with Applepay:
{
    "amount": 650,
    "currency": "USD",
    "confirm": true,
    "amount_to_capture": 650,
    "customer_id": "test_fb",
    "capture_method": "automatic",
    "capture_on": "2022-09-10T10:11:12Z",
    "authentication_type": "three_ds",
    "return_url": "https://google.com",
    "email": "[email protected]",
    "name": "Joseph Doe",
    "phone": "999999999",
    "phone_country_code": "+65",
    "description": "Its my first payment request",
    "statement_descriptor_name": "Juspay",
    "statement_descriptor_suffix": "Router",
    "payment_method": "wallet",
    "payment_method_type": "apple_pay",
    "payment_method_data": {
        "wallet": {
            "apple_pay": {
                "payment_data": "{{payment_data}}",
                "payment_method": {
                    "display_name": "MasterCard 7599",
                    "network": "MasterCard",
                    "type": "credit"
                },
                "transaction_identifier": "{{transaction_identifier}}"
            }
        },
        "billing": {
            "address": {
                "line1": "jhkdsa",
                "zip": "10000",
                "last_name": "chikke",
                "city": "adf",
                "country": "US",
                "first_name": "srujan",
                "state": "Alabama"
            },
            "email": "[email protected]"
        }
    }
}
  • The payment should succeed

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Sakilmostak Sakilmostak added A-connector-integration Area: Connector integration C-bug Category: Bug labels Dec 3, 2024
@Sakilmostak Sakilmostak self-assigned this Dec 3, 2024
@Sakilmostak Sakilmostak requested a review from a team as a code owner December 3, 2024 08:38
Copy link

semanticdiff-com bot commented Dec 3, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/connector/cybersource/transformers.rs  0% smaller

@Sakilmostak
Copy link
Contributor Author

Closing since the hotfix needs to be raised by same author

@Sakilmostak Sakilmostak closed this Dec 3, 2024
@Sakilmostak Sakilmostak reopened this Dec 3, 2024
@Sakilmostak Sakilmostak changed the title fix(router): populate card network in the network transaction id based MIT flow fix(connector): [Cybersource] change commerce indicator for discover cards in apple pay Dec 3, 2024
@SanchithHegde SanchithHegde merged commit 344a882 into hotfix-2024.11.27.0 Dec 3, 2024
33 of 49 checks passed
@SanchithHegde SanchithHegde deleted the applepay_discover_fix branch December 3, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants