Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System labels should not be displayed when editing labels for an execution #6206

Open
fhussonnois opened this issue Nov 29, 2024 · 2 comments
Labels
area/frontend Needs frontend code changes bug Something isn't working

Comments

@fhussonnois
Copy link
Member

Describe the issue

Currently, when editing labels for an execution system labels are displayed.

kestra-system-labels

We should hide them because system labels cannot be removed/edited/added by a user.

A user could be tempted to modify them, which would lead to an error and degrade the user experience;

system-label-error

Environment

  • Kestra Version: develop
@fhussonnois fhussonnois added bug Something isn't working area/frontend Needs frontend code changes labels Nov 29, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Nov 29, 2024
@MilosPaunovic
Copy link
Member

This was handled by @loicmathieu few days ago, just waiting for him to confirm and close if alright now.

@loicmathieu
Copy link
Member

There is no more issue as the backend check that the system labels passed by the frontend are the same that the existing one.
But here, Florian said that it would be better to avoid displaying them at all.

As it's not a big deal, let's move this in 0.21, @anna-geller or @Ben8t could then decided if it needs to be done or if it's OK like this.

@loicmathieu loicmathieu removed their assignment Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Needs frontend code changes bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

3 participants