-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add ability to toggle glass frame scroll motion #102
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Scroll still animates the background when the viewport size changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, I actually didn't know much about background-attachment
and its implementation, learned something new there 👍
Still, 1 feedback point to improve the guideline.
I just found a video in which it seems like I'll have to install Windows 7 myself to verify but in that case I would make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, lemme know when it's ready and I'll merge it in.
Hi,
This PR changes the default glass background behavior to be non-moving.
The old behavior can be enabled again by adding a class to the window, I also added another example for this to the documentation (into the "Glass frame & Color" section), so the difference is directly visible.
Thanks