Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add ability to toggle glass frame scroll motion #102

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

lfuelling
Copy link
Contributor

@lfuelling lfuelling commented Oct 30, 2024

Hi,

This PR changes the default glass background behavior to be non-moving.
The old behavior can be enabled again by adding a class to the window, I also added another example for this to the documentation (into the "Glass frame & Color" section), so the difference is directly visible.

Thanks

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
7css ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 11:17pm

Scroll still animates the background when the viewport size changes
@lfuelling lfuelling changed the title Add ability to toggle glass background scroll motion Add ability to toggle glass frame scroll motion Oct 30, 2024
Copy link
Owner

@khang-nd khang-nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, I actually didn't know much about background-attachment and its implementation, learned something new there 👍

Still, 1 feedback point to improve the guideline.

docs/components/window/frame.ejs Outdated Show resolved Hide resolved
@lfuelling lfuelling changed the title Add ability to toggle glass frame scroll motion [WIP] Add ability to toggle glass frame scroll motion Oct 31, 2024
@lfuelling
Copy link
Contributor Author

I just found a video in which it seems like fixed would actually be the correct behavior.

I'll have to install Windows 7 myself to verify but in that case I would make fixed the explicit default and update the example just in case someone needs the other behavior.

Copy link
Owner

@khang-nd khang-nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, lemme know when it's ready and I'll merge it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants