Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a library to generate and manipulate XML documents #124

Open
aglitke opened this issue Sep 11, 2013 · 3 comments
Open

Use a library to generate and manipulate XML documents #124

aglitke opened this issue Sep 11, 2013 · 3 comments
Milestone

Comments

@aglitke
Copy link
Member

aglitke commented Sep 11, 2013

While it seems like less code to use template strings to produce XML documents for libvirt, this approach can be error prone and may lead to security problems if escaping is not handled properly. We should adopt a library such as libxml2 or xml.etree for managing this in most cases.

@ramonmedeiros
Copy link

Hi Adam,

it seems that you want a class to compose the xml for libvirt. How you want this feature:

1 - Pass a dictionary in python with the information and generate a libvirt xml as output?
2 - Create a class, with functions like setOS, setArch to create the xml

@shaohef
Copy link

shaohef commented Oct 13, 2013

aglitke: we looked at using libvirt-gobject to help us manipulate xml files. The problem is this is not available on rhel5
It's a wrapper library for libvirt using gobject introspection to provide the python bindings.

@aglitke do we still consider libvirt-gobject?

@aglitke
Copy link
Member Author

aglitke commented Oct 14, 2013

On Sun, Oct 13, 2013 at 08:38:31AM -0700, shaohef wrote:

aglitke: we looked at using libvirt-gobject to help us manipulate xml files. The problem is this is not available on rhel5
It's a wrapper library for libvirt using gobject introspection to provide the python bindings.

@aglitke do we still consider libvirt-gobject?

No. I think we should use libxml2.


Reply to this email directly or view it on GitHub:
#124 (comment)

Adam Litke [email protected]
IBM Linux Technology Center

@alinefm alinefm added this to the 1.2.1 GA milestone Apr 24, 2014
@alinefm alinefm removed this from the 1.2.1 GA milestone Jul 2, 2014
@alinefm alinefm added this to the Backlog milestone Dec 3, 2014
@alinefm alinefm modified the milestones: Kimchi 1.4.1, Backlog Dec 24, 2014
@cd1 cd1 modified the milestones: Kimchi 1.4.1, Backlog Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants