Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vnc: Scale display to the size of the window #146

Open
aglitke opened this issue Sep 18, 2013 · 5 comments
Open

vnc: Scale display to the size of the window #146

aglitke opened this issue Sep 18, 2013 · 5 comments
Labels
enhancement UI
Milestone
Backlog

Comments

@aglitke
Copy link
Member

aglitke commented Sep 18, 2013

When the screen resolution of a VM's VNC display is larger than the browser window we add scrollbars to the side of the screen. It would be much more user-friendly if we scaled the display to the window size so that the full desktop is always in view.
@shaohef
Copy link

shaohef commented Oct 13, 2013

@zhoumeina can you fix this?
not sure you should read up the RFB protocol.
$ git show fe48e63

@zhoumeina
Copy link

It should be RFB

@ghost ghost assigned zhoumeina Oct 16, 2013
@zhoumeina
Copy link

Open a issue to noVNC novnc/noVNC#312

@zhoumeina
Copy link

noVNC is trying to solve this issue. and sent patches to support "ExtendedDesktopSize" encoding which already present in the RFB protocol.

I will track #271 in noVNC.

@alinefm alinefm added this to the Backlog milestone Dec 3, 2014
@alinefm alinefm added the UI label Dec 18, 2015
@overcookedTOFU
Copy link
Contributor

Hi, It looks to me like novnc/noVNC#271 has been merged in noVNC for a bit. Any hope of this change being implemented in Kimchi? Thanks!

patchew-importer pushed a commit to patchew-project/kimchi that referenced this issue Apr 23, 2018
@alinefm
Bug fix kimchi-project#146: Do not display Wok tab for non-admin users
d84f137 
The Wok tab is restricted to admin users so do not load it for non-admin
users. It implies in changing the way Wok loads the tabs as all the
children tabs may be hidden for non-admin users and consequently the
pattern tab should not be loaded as well.

Signed-off-by: Aline Manera <[email protected]>
patchew-importer pushed a commit to patchew-project/kimchi that referenced this issue May 25, 2018
@alinefm
Bug fix kimchi-project#146: Do not display Wok tab for non-admin users
5835544 
The Wok tab is restricted to admin users so do not load it for non-admin
users. It implies in changing the way Wok loads the tabs as all the
children tabs may be hidden for non-admin users and consequently the
pattern tab should not be loaded as well.

Signed-off-by: Aline Manera <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement UI
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@aglitke @overcookedTOFU @alinefm @shaohef @zhoumeina