Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert info message when the browser version is unsupported or low edition #79

Open
zhoumeina opened this issue Aug 2, 2013 · 9 comments

Comments

@zhoumeina
Copy link

If the browser version were not in the browser support list, we want to give the user a message to tell them "update the brower" or "the current is not supported, try....." or something.

@shaohef
Copy link

shaohef commented Aug 2, 2013

That's very useful to user.

@adamkingit
Copy link
Contributor

Thi can be a double edged sword. You either have to spend time chasing and updating the list, or you have to assume >= a particular version which doesn't always work as well as you might think.

@shaohef
Copy link

shaohef commented Oct 14, 2013

@aglitke and @sming56 do we will support this feature?
Seems it is useful.
IMHO, we should not support IE8, IE8 is not friendly for html5.
but many users still use IE8.
We can prompt them to upgrade their IE.

@aglitke
Copy link
Member

aglitke commented Oct 14, 2013

On Sun, Oct 13, 2013 at 07:48:15PM -0700, shaohef wrote:

@aglitke and @sming56 do we will support this feature?
Seems it is useful.
IMHO, we should not support IE8, IE8 is not friendly for html5.
but many users still use IE8.
We can prompt them to upgrade their IE.

Seems reasonable. Maybe have an alert on the login screen.


Reply to this email directly or view it on GitHub:
#79 (comment)

Adam Litke [email protected]
IBM Linux Technology Center

@sming56
Copy link

sming56 commented Oct 14, 2013

Agree. We can tell the user if he want a good quality of the UI, IE9 at least if a legacy IE browser is detected. We can display the warning message before the login window popups.

@ghost
Copy link

ghost commented Oct 14, 2013

I'd like to take this one. Would you please assign it to me?

@ghost ghost self-assigned this Oct 14, 2013
@ghost
Copy link

ghost commented Oct 14, 2013

@sming56 one alternative is to show a new popup window before the login screen, where the user can click to see upgrade instructions or click a checkbox to dismiss. Or we could show a short text message inside the login window, below the login credentials, saying "Browser not fully supported" and provide a link for details and a checkbox to dismiss.

Any suggestions?

@hlwanghl
Copy link

@rangell I suggest to have a single page for it, just like error 404 page. This will help avoid unexpected page rendering of the tabs, pop-up window if the browser is too old to support jQuery.
In the single page, we can do several things:

  1. show incompatible message like: "Sorry, only the following browsers are supported current. You can click one of the following browser links to get one; or <button>Continue with your browser anyway.</button>
  2. Provide option to allow save user's choose. <input type="checkbox">save my choice</input> This will need cookie manipulation through kimchi.cookie.
  3. A list of supported browsers with their icons and official website links.

@shaohef
Copy link

shaohef commented Oct 15, 2013

@rangell sure. your are welcome to take this.

@aglitke can I apply the privilege of the github?

@alinefm alinefm added this to the Backlog milestone Dec 3, 2014
@alinefm alinefm changed the title [enhance] UI: alert info message when the browser version is unsupported or low edition Alert info message when the browser version is unsupported or low edition Dec 18, 2015
@alinefm alinefm added the UI label Dec 18, 2015
patchew-importer pushed a commit to patchew-project/kimchi that referenced this issue Apr 23, 2018
…ser dismiss it

This commit also fixes a bug where alert "close" buttons would close modal windows.

Signed-off-by: Samuel Guimarães <[email protected]>
patchew-importer pushed a commit to patchew-project/kimchi that referenced this issue May 25, 2018
…ser dismiss it

This commit also fixes a bug where alert "close" buttons would close modal windows.

Signed-off-by: Samuel Guimarães <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants