Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib directory missing in HEAD #23

Open
hongxuchen opened this issue Dec 3, 2018 · 5 comments
Open

lib directory missing in HEAD #23

hongxuchen opened this issue Dec 3, 2018 · 5 comments
Assignees

Comments

@hongxuchen
Copy link

The lib directory that contains Gnulib C files seems missing from this repository, despite that it's there inside release versions:http://lbzip2.org/download.

@hanetzer
Copy link

Intentional. If you check the same page you linked, it will tell you the git repo does not
contain any autgenerated files (configure) or third-party code (all of lib).

@hongxuchen
Copy link
Author

Thanks for clarification and sorry I didn't read the content on that page or the BOOTSTRAP file carefully.
Personally I think it's better to mention BOOTSTRAP file or ./build-aux/autogen.sh in README.

@kjn kjn self-assigned this Dec 26, 2018
@kjn
Copy link
Owner

kjn commented Dec 26, 2018

Although I generally don't like checking generated files into SCM, I am now considering adding Gnulib and Autotools-generated build files into Git repository to ease contribution and to make release tarballs closer (or identical) to contents of the repository.

@hanetzer
Copy link

@kjn bit late, but I'd personally suggest against it. Too much churn, what @hongxuchen said
about mentioning it may be enough.

@logological
Copy link

I partially agree with @hanetzerit is a bad idea to check files generated by Autotools into the source repository. However, gnulib files aren't generated so it might make sense to include them. An alternative would be to add the gnulib source repository as a Git submodule. (I have seen other projects that depend on gnulib do this.) You would still need to provide a bootstrap script (or at least remind developers to do a git submodule init;git submodule update or to clone the repository recursively) but at least you won't be unnecessarily duplicating any gnulib code in your repository, and you have an easy, enforceable way of specifying which version of gnulib to include in the source distribution (since submodules always point to a specific commit ID).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants