Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop mako code and dependency #2820

Closed
ReToCode opened this issue Sep 14, 2023 · 5 comments · Fixed by #3060
Closed

Drop mako code and dependency #2820

ReToCode opened this issue Sep 14, 2023 · 5 comments · Fixed by #3060
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@ReToCode
Copy link
Member

We removed the dependency to mako from Serving in knative/serving#14289.

With this no longer used, the mako go depencendy and all the stub code here in pkg can be dropped.

Work needed

  • Check for usage of mako in all knative and knative-extensions repositories prior to deleting it here
  • Drop mako golang dependency
  • Drop code at "knative.dev/pkg/test/mako/stub-sidecar"
  • Find other references (if any) and drop them as well
@ReToCode ReToCode added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/good-first-issue Denotes an issue ready for a new contributor. labels Sep 14, 2023
@ReToCode
Copy link
Member Author

Eventing still has a dependency on the mako-stub. So this task is on hold, until this dependency is removed.

@ReToCode ReToCode added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed kind/good-first-issue Denotes an issue ready for a new contributor. labels Sep 14, 2023
@dprotaso
Copy link
Member

cc @pierDipi do you plan on continuing using this stub?

@pierDipi
Copy link
Member

I'm not aware of anybody using the performance tests in Eventing, I believe we can remove them and with that the mako usage

@pierDipi
Copy link
Member

knative/eventing#7707

@pierDipi
Copy link
Member

pierDipi commented Apr 3, 2024

@Zerpet @ikavgo @mkuratczyk eventing-rabbitmq is using the mako-stub for performance tests, do you still need the mako stub or are you migrating off of it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants