Fix parsing no content into null instead of 'null' (#911)

knuckleswtf · Nov 5, 2024 · 6837c03 · 6837c03
1 parent da667aa
commit 6837c03
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/Attributes/Response.php b/src/Attributes/Response.php
@@ -18,7 +18,11 @@ public function toArray()
     {
         return  [
             "status" => $this->status,
-            "content" => is_string($this->content) ? $this->content : json_encode($this->content, JSON_THROW_ON_ERROR),
+            "content" => match (true) {
+                is_null($this->content) => null,
+                is_string($this->content) => $this->content,
+                default => json_encode($this->content, JSON_THROW_ON_ERROR),
+            },
             "description" => $this->description,
         ];
     }

diff --git a/tests/Strategies/Responses/UseResponseAttributesTest.php b/tests/Strategies/Responses/UseResponseAttributesTest.php
@@ -73,6 +73,10 @@ public function can_parse_plain_response_attributes()
                 'status' => 201,
                 'content' => json_encode(["all" => "good"]),
             ],
+            [
+                'status' => 404,
+                'content' => null,
+            ]
         ], $results);
     }
 
@@ -246,6 +250,7 @@ class ResponseAttributesTestController
 {
     #[Response(["all" => "good"], 200, "Success")]
     #[Response('{"all":"good"}', 201)]
+    #[Response(status: 404)]
     public function plainResponseAttributes()
     {