Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godbolt example broken #259

Open
adayton1 opened this issue May 3, 2023 · 1 comment
Open

Godbolt example broken #259

adayton1 opened this issue May 3, 2023 · 1 comment

Comments

@adayton1
Copy link

adayton1 commented May 3, 2023

It looks like the latest commit to the single-header branch broke things. There are a bunch of errors regarding redefinitions (one example is below):

In file included from <source>:11:
/app/raw.githubusercontent.com/kokkos/mdspan/single-header/mdspan.hpp:1111:8: error: redefinition of 'struct std::default_accessor<ElementType>'
 1111 | struct default_accessor {
      |        ^~~~~~~~~~~~~~~~
/app/raw.githubusercontent.com/kokkos/mdspan/single-header/mdspan.hpp:1011:8: note: previous definition of 'struct std::default_accessor<ElementType>'
 1011 | struct default_accessor {
      |        ^~~~~~~~~~~~~~~~

I went back to the previous commit and it worked fine (https://raw.githubusercontent.com/kokkos/mdspan/15563ed9ab955f8a2e555181a71583a9913816c2/mdspan.hpp instead of https://raw.githubusercontent.com/kokkos/mdspan/single-header/mdspan.hpp).

@crtrott
Copy link
Member

crtrott commented May 3, 2023

I think this will fix it. #260
Note that by default however the single header will give you mdspan from now on in the Kokkos:: namespace.

Technically we are not allowed to inject things into the std:: namespace without being a stdandard library implementation.

mhoemmen added a commit to mhoemmen/mdspan that referenced this issue Jul 26, 2023
Removed anonymous namespace from blas3_matrix_product.hpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants