Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kpt live destroy command should be able to wait for resources to be removed #1461

Open
mortent opened this issue Feb 15, 2021 · 0 comments
Open
Labels
area/live enhancement New feature or request p1 size/L 4 day triaged Issue has been triaged by adding an `area/` label

Comments

@mortent
Copy link
Contributor

mortent commented Feb 15, 2021

The kpt live destroy command currently doesn't have parity with the kpt live apply command. In particular two pieces stand out:

  • It doesn't allow the --prune-propagation-policy and --prune-timeout flags that allow users to specify whether we should wait for resources to be deleted, and if so, for how long.
  • The Applier.Run function returns an init event on the channel with information about which resources will be applied/pruned. This is used by the table UI to be able to create the list of resources and their state before any changes are made. The Deployer should use a similar solution.
@mortent mortent added enhancement New feature or request area/live size/L 4 day p1 labels Feb 15, 2021
@mikebz mikebz added the triaged Issue has been triaged by adding an `area/` label label Feb 16, 2021
@mortent mortent added this to kpt Jan 21, 2023
@mortent mortent moved this to Backlog in kpt Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/live enhancement New feature or request p1 size/L 4 day triaged Issue has been triaged by adding an `area/` label
Projects
None yet
Development

No branches or pull requests

2 participants