Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skeleton for Jaeger_demo #62

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Skeleton for Jaeger_demo #62

wants to merge 7 commits into from
+410 −1

Conversation

ozer550
Copy link
Contributor

@ozer550 ozer550 commented Jul 26, 2023

WIP

ozer550 added 3 commits July 26, 2023 12:58
@ozer550
Skeleton for jaeger_demo
8e1c04b 
Signed-off-by: Prathamesh Desai <[email protected]>
@ozer550
portforward jaeger service
f0e6aab 
Signed-off-by: Prathamesh Desai <[email protected]>
@ozer550
clean up code
d4965b1 
Signed-off-by: Prathamesh Desai <[email protected]>
@ozer550 ozer550 marked this pull request as ready for review July 28, 2023 07:40
ozer550 added 2 commits July 28, 2023 16:24
@ozer550
Change clone to kruize repo
b59f5d9 
Signed-off-by: Prathamesh Desai <[email protected]>
@ozer550
Update based on reccomendation
ff8a38e 
Signed-off-by: Prathamesh Desai <[email protected]>
chandrams
chandrams reviewed Jul 31, 2023
View reviewed changes
Copy link
Contributor

@chandrams chandrams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include a README explaining the Jaeger demo and display the json or add some instructions to view the dependency json at the end of the script.

chandrams
chandrams reviewed Jul 31, 2023
View reviewed changes
jaeger_demo_setup.sh Outdated
@@ -0,0 +1,326 @@
#!/bin/bash
#
# Copyright (c) 2020, 2022 Red Hat, IBM Corporation and others.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change 2022 -> 2023

jaeger_demo_setup.sh Outdated
Jaeger_demo_install
fi
kruize_install
# autotune_install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented code

ozer550 added 2 commits July 31, 2023 14:41
@ozer550
more review fixes
b26053a 
Signed-off-by: Prathamesh Desai <[email protected]>
@ozer550
Change copy right certificate date
f0a9d58 
Signed-off-by: Prathamesh Desai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandrams chandrams chandrams left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ozer550 @chandrams