Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this tool support pipes? #27

Open
tomerh2001 opened this issue Sep 30, 2023 · 3 comments
Open

Does this tool support pipes? #27

tomerh2001 opened this issue Sep 30, 2023 · 3 comments
Assignees
Labels
feedback-appreciated curious for feedback and/or responses of open questions

Comments

@tomerh2001
Copy link

I am getting this weird output:

+ echo "pipe: atlassian/git-secrets-scan:1.4.0 (pending feature)" # pipe feature is pending
printf %s '  FILES_IGNORED (**/node_modules): '; printf '%s ' **/node_modules; printf '\n' 

pipe: atlassian/git-secrets-scan:1.4.0 (pending feature)
  FILES_IGNORED (**/node_modules): **/node_modules 
@ktomk
Copy link
Owner

ktomk commented Sep 30, 2023

The "pipe feature is pending" as commented in the first line of the output and more specifically:

pipe: atlassian/git-secrets-scan:1.4.0 (pending feature)

That means support for pipes is not fully implemented, only some (little) part of it works.

This is documented in the Todo only:

Selection_301

What you see is the "Fake run script with pipe/s showing information", so what you received "weird" is a pure fake (it only produces some output but does not run the pipe).

I'm sorry if that caused any inconvenience. I've not given it much traction because many pipes make use of remote interactions and I was mainly using it offline. It could be that the atlassian/git-secrets-scan pipe would not do so, but I've never used it, similar to other pipes and therefore didn't implement further.

The pipe feature would require to create a dedicated Docker mount of the copied or mounted project directory (that is apart from the --deployment option and its argument) so that any pipe can operate with it. IIRC, that was the concrete blocker as it needs to be transparent for both existing modes.

So what the current implementation does, is faking the call and continuing with the next steps if there are any. So every pipe is a no-op (no operation), but also not a failure.

@ktomk ktomk self-assigned this Oct 1, 2023
@ktomk ktomk added the feedback-appreciated curious for feedback and/or responses of open questions label Oct 1, 2023
@tomerh2001
Copy link
Author

@ktomk Uh, I see, thank you. I mainly wanted to use this tool to test the pipes I'm creating, any plan to support pipes in the future?

@ktomk
Copy link
Owner

ktomk commented Oct 3, 2023

Not sure, I would need to look into this and no idea when that will be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback-appreciated curious for feedback and/or responses of open questions
Projects
None yet
Development

No branches or pull requests

2 participants