Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Check whether the path to delete is a subdirectory of kuzu database path #4529

Open
acquamarin opened this issue Nov 15, 2024 · 0 comments · May be fixed by #4543
Open

Feature: Check whether the path to delete is a subdirectory of kuzu database path #4529

acquamarin opened this issue Nov 15, 2024 · 0 comments · May be fixed by #4543
Assignees
@acquamarin @SterlingT3485
Labels
feature New features or missing components of existing features

Comments

@acquamarin
Copy link
Collaborator

API

Python

Description

The current implementation of removeFileIfExists(const std::string& path) is unsafe since it can delete arbitrary files on disk.
We should consider adding a guard that it can only delete files under the current running database path.
@acquamarin acquamarin added the feature New features or missing components of existing features label Nov 15, 2024
@acquamarin acquamarin self-assigned this Nov 15, 2024
@SterlingT3485 SterlingT3485 self-assigned this Nov 18, 2024
@SterlingT3485 SterlingT3485 linked a pull request Nov 18, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acquamarin acquamarin

@SterlingT3485 SterlingT3485

Labels
feature New features or missing components of existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a homeDir field in LocalFileSystem for removefile to check kuzudb/kuzu
2 participants
@acquamarin @SterlingT3485