Improve robustness against BM exceptions #4423
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royi-luo
force-pushed
the
royi/fix-4338
branch
4 times, most recently
from
c0e06f3
to
352233b
Compare
Improve exception robustness Add test for copy rel group Avoid transferring column ownership to checkpoint state Cleanup empty node groups after exception in separate step Add same connection test Throw batch insert error before attempting delete (which should be ignore errors only) Fix empty node group removing + remove unneeded changes Avoid nullptr dereference in Database destructor Hack fix to hash index exception during checkpoint recovery Undo buffer operates on node group Remove cleanup phase Append node group to collection as late as possible (to avoid BM exceptions occurring between append + populate) Fix switch fall through Undo buffer insert operates on table instead of node group Hacked hash index fix pt 2 Undo buffer changes for rel table NodeGroupCollection responsible for pushing transaction insert info Skip correct column when commiting rel table Fix commitInsert for children More fixes Fix WIP
royi-luo
force-pushed
the
royi/fix-4338
branch
from
46147cb
to
16917f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed bugs:
Fixes #4338
Contributor agreement