Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module makes nginx 1.23.* crash if enabled #249

Open
freultwah opened this issue Aug 21, 2022 · 4 comments
Open

Module makes nginx 1.23.* crash if enabled #249

freultwah opened this issue Aug 21, 2022 · 4 comments

Comments

@freultwah
Copy link

nginx 1.23 has apparently seen massive API changes, and while nginx-auth-ldap still builds, it does make nginx 1.23.* exit with signal 10 and signal 11 if enabled. Disabling the module makes nginx great again.

Any plans on addressing it?

@episodeiv
Copy link

For anyone finding this: @freultwah was nice enough to provide pull request #250 which works in my environment but hasn't been merged yet...
Thanks, @freultwah :-)

@landryb
Copy link
Contributor

landryb commented Apr 25, 2024

i have to admit that i'm puzzled, since im running this module on 1.24 and 1.26 without issues using this config:

ldap_server ldap1_main {
        url ldap://db2/ou=users,dc=foo,dc=bar?uid?sub?(objectClass=*);
        group_attribute member;
        group_attribute_is_dn on;
        satisfy all;
        require group "cn=SOME_GROUP,ou=roles,dc=foo,dc=bar";
        require valid_user;
}
ldap_server ldap1_extern_other {
        url ldap://db2/ou=other,ou=wxs,dc=foo,dc=bar?uid?sub?(objectClass=*);
        require valid_user;
}

i've never seen crashes and many users are authenticating against the service... looking at the fix in #250 and #253 and 221529c, it seems to be because i don't ask for any ldap attributes ?

@freultwah
Copy link
Author

Perhaps you're running an already patched version. My config is even slightly simpler than yours, no (objectClass=*) and also no attributes requested.

@landryb
Copy link
Contributor

landryb commented Apr 25, 2024

well that's what surprises me because i run the master branch of that repo without patches, built as a debian package and dlopen'ed module at runtime by nginx upstream debian packages...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants