Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use semantic versioning for kyma modules (managers) #18410

Open
9 tasks done
pbochynski opened this issue Nov 15, 2023 · 10 comments
Open
9 tasks done

Use semantic versioning for kyma modules (managers) #18410

pbochynski opened this issue Nov 15, 2023 · 10 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@pbochynski
Copy link
Contributor

pbochynski commented Nov 15, 2023

Description

According to the modularization concept modules artifacts should use semantic versioning (semver.org). This requirement was fulfilled by the front runners modules, but is not consequently applied by other modules. Here are the latest released versions of module managers (operators):

  • europe-docker.pkg.dev/kyma-project/prod/istio-manager:1.1.2
  • europe-docker.pkg.dev/kyma-project/prod/api-gateway-manager:2.0.0
  • europe-docker.pkg.dev/kyma-project/prod/serverless-operator:1.4.3
  • europe-docker.pkg.dev/kyma-project/prod/btp-manager:1.0.1
  • europe-docker.pkg.dev/kyma-project/prod/telemetry-manager:v20231106-2bbe91ce (Remove moduleTemplate usage from module releases and documentation telemetry-manager#566)
  • europe-docker.pkg.dev/kyma-project/prod/nats-manager:3aee6dc4bd47f62c72caf19557d717e8c2706527
  • europe-docker.pkg.dev/kyma-project/prod/eventing-manager:49b1192071ec05bfdd18c1f667544ac34aa927a1
  • europe-docker.pkg.dev/kyma-project/prod/application-connector-manager:v20231106-bfc94e9f
  • europe-docker.pkg.dev/kyma-project/prod/keda-manager:1.0.0

Expected result
All modules use semantic versioning

Actual result

Steps to reproduce

Troubleshooting

@pbochynski pbochynski added the kind/bug Categorizes issue or PR as related to a bug. label Nov 15, 2023
@Disper
Copy link
Member

Disper commented Nov 16, 2023

@koala7659, @m00g3n, I thought that we already switched to semver with 1.0.3.
Could you have a look?

@koala7659
Copy link
Contributor

@pbochynski We use semantic versioning for application-connector-module. Version 1.0.3 is available in both fast and regular channel

@Disper
Copy link
Member

Disper commented Nov 16, 2023

@pbochynski could you elaborate where the ACM is not using semver?

  • We have switched to the 1.0.3 release tag
  • In the Kyma Dashboard the 1.0.3 version is available
    image

@pbochynski
Copy link
Contributor Author

@Disper When you look into the released deployment you can find that the operator is in version:

europe-docker.pkg.dev/kyma-project/prod/application-connector-manager:v20231106-bfc94e9f

If you want to check which version is applied in your cluster you have to download the yaml file from release artifacts and check what is inside. If the version matches your deployment then you know the version. Wouldn't it be easier if you follow the pattern we established with the modularization front runners (keda, btp-manager, serverless) and use semantic versioning for module manager?

Copy link

github-actions bot commented May 6, 2024

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 6, 2024
@a-thaler a-thaler removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 6, 2024
@a-thaler
Copy link
Contributor

a-thaler commented May 6, 2024

@Disper application-connector-manager is still not following that convention

@tobiscr
Copy link
Contributor

tobiscr commented May 7, 2024

@a-thaler : we will pick it up as part of our release process automation and fix it in coming sprint(s). Have to see how fast we can implement the process, but we have it on the radar. Issue for release process automation is kyma-project/application-connector-manager#104.

Copy link

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2024
@a-thaler a-thaler removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 19, 2024
Copy link

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 19, 2024
@a-thaler a-thaler removed their assignment Oct 19, 2024
@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

7 participants