Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support maintenance window for module upgrades #18611

Open
pbochynski opened this issue Mar 14, 2024 · 8 comments
Open

Support maintenance window for module upgrades #18611

pbochynski opened this issue Mar 14, 2024 · 8 comments
Assignees
Labels

Comments

@pbochynski
Copy link
Contributor

pbochynski commented Mar 14, 2024

Description
Requirements:

  • possibility to mark versions that require a maintenance window
  • possibility to assign clusters to maintenance windows (maintenance windows can be different for regions, customers, etc)

Modules should still be reconciled to make sure that the Manifest is healthy, given module upgrades should happen ONLY during the maintenance window.

Reasons

Some module upgrades can come with service disruption that should be handled within the maintenance window.

Implementation Concept

  • Module version should get additional attribute (requires downtime)
  • Maintenance windows should be assigned to the landscape, region, or individual Kyma instance (maybe annotation in the Kyma CR in KCP)
  • KLM should respect maintenance widows
  • The user should be able to override the default maintenance window (annotating Kyma CR in the cluster)

Acceptance Criteria

  • Describe the Maintenance Window behaviour
    • Given a Kyma Module in the Kyma Module Catalogue
      • When a new Kyma Module version is added to the Kyma Module Catalogue
        • Then an entry in Module Catalogue is updated
          • And the Kyma Module entry contains information whether a new version of Kyma Module should be upgraded during the Maintenance Window
      • When the Lifecycle Manager reconciles Kyma Module
        • And the new version of the Kyma Module is available and requires a Maintenance Window
          • And the Maintenance Window is currently active
            • Then the Kyma Module is upgraded to the new version
          • And the Maintenance Window is currently not active
            • Then the Kyma Module is not upgraded and reconciled in the current version until the Maintenance Window is active
          • ❓ And the User chose to ignore maintenance window
            • Then the Kyma Module is upgraded to the new version
@janmedrek
Copy link
Contributor

Multiple versions of the modules will be introduced in this epic: kyma-project/lifecycle-manager#1472

Until then, there is no persistence of multiple module version and thus, this ticket is blocked.

@jeremyharisch
Copy link
Contributor

Acceptance Criteria for EPIC:

  • Research about the topic
  • Think about a proper issue split for this EPIC
  • Create Sub-Issues to cover the implementation
  • Regarding business requirements talk to @janmedrek if needed

Timebox: 2 Days

@lindnerby lindnerby removed their assignment Jun 4, 2024
@ebensom
Copy link
Member

ebensom commented Jul 5, 2024

@janmedrek @kyma-project/jellyfish The specification of the maintenance window policy to be supported by KLM:
https://github.tools.sap/kyma/backlog/issues/5462#issuecomment-6963879

The same will be supported (ehhanced) in the orchestration operatoror developed by us.

@ebensom
Copy link
Member

ebensom commented Aug 26, 2024

@janmedrek when do you plan to start woring on this epic?

Starting from 2025 Q1 we must execute all module rollouts impacting availability in the harmonized BTP major upgrade windows. Hence this feature of KLM should be delivered latest by end of Q4.

@janmedrek janmedrek self-assigned this Sep 25, 2024
@janmedrek
Copy link
Contributor

Existing code for parsing policies and resolving maintenance windows - internal link

@janmedrek
Copy link
Contributor

We would need following information from KEB to be put on Kyma CR in KCP:

  "globalAccountID": string
  "plan": string
  "region": string
  "platformRegion": string

@janmedrek
Copy link
Contributor

@ebensom perhaps it would make sense to make a separate Go library for that? I believe that would be beneficial as it seems multiple sources will re-use that logic to resolve maintenance windows.

@ebensom
Copy link
Member

ebensom commented Nov 22, 2024

@janmedrek that's a good idea. Should we put it somewhere in the kyma-project/kyma repo, under pkg?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants