-
Notifications
You must be signed in to change notification settings - Fork 211
Add CI for code style verifications #268
Comments
Check out https://styleci.io/. :) |
That way you can keep travis reserved for the unit tests, and have styleci giving an additional green/red light on PRs. |
That's awesome! I didn't know that service. |
Unable to implement StyleCI. I'm not the owner of the project... And I'm quite sure @laravelbook won't even try to reply us. |
I'll send him an email asking for help. TravisCI behaves the same way (why did I though it would be different? lol) |
@igorsantos07 If you need any help, feel free to contact me, and I can help you get set up, though I can't manually enable this repo on StyleCI for you until someone with admin permissions on this repo has an account on StyleCI because we'd be using their authentication token in order to use GitHub's status API. Non-admin users don't have permission to write to the status API for their repos you see. :) |
Yeah... That's way too bad. Not because of the API, but the other way I'll try to investigate things later today and see what I can came up with
|
It's imperative we include Travis CI support to verify code styling issues, as PRs usually come with different code styles and that reduces code quality.
In the future we can use this integration for tests as well.
Suggestion: verify how Faker does it.
The text was updated successfully, but these errors were encountered: