Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: External links (x-callback-url) do not work between notes #11455

Open
graphit0 opened this issue Nov 30, 2024 · 1 comment
Open

Mobile: External links (x-callback-url) do not work between notes #11455

graphit0 opened this issue Nov 30, 2024 · 1 comment
Labels
bug It's a bug

Comments

@graphit0
Copy link

graphit0 commented Nov 30, 2024

Operating system

Android

Joplin version

Android 3.1.6-3.2.2

Desktop version info

Joplin 3.2.3 (prod, linux)

Client ID: 169b6340643343e29989371d139b9ebe
Sync Version: 3
Profile Version: 47
Keychain Supported: Yes

Revision: 1993d30

Backup: 1.4.2
CodeMirror 6 snippets: 0.0.8
Extra Markdown editor settings: 1.5.0
Joplin Batch: 0.2.2
Note list (Preview): 1.1.0
Quick Links: 1.3.2
Rich Markdown: 0.15.1

Current behaviour

Description

Users are reporting that in Joplin Android versions 3.1.6-3.2.2, clicking on links within notes that use the joplin://x-callback-url/openNote?id= format do not function as expected. When such a link is clicked inside a note, nothing happens. However, these same links work correctly when opened from outside the app, such as from another application.

This behavior differs from version 3.0.7, where both types of internal note links worked properly within notes. In earlier versions before 3.0.7, these links did not work inside notes, but an error window was displayed, providing feedback to the user.

Steps

  1. Create a note with a link in the format joplin://x-callback-url/openNote?id=note_id.
  2. Tap on this link while viewing the note in Joplin Android versions 3.1.6+

Actual Behavior

Nothing happens when the link is tapped. There is no response or error message.

Expected behaviour

Tapping on the link should open the note corresponding to the provided note_id.

Notes

  • The link works correctly when opened from outside the app, indicating that the link format is valid and the app can handle it externally.
  • In version 3.0.7, both types of internal note links worked inside notes.
  • In versions prior to 3.0.7, these links did not work inside notes, but an error window was displayed.
  • On desktop version the same external link opens properly.

Screen recording

screen-20241130-193354.mp4

Logs

11-30T19:18:48: openItemCommand: Invalid Joplin link: joplin://x-callback-url/openNote?id=5453d37feb4e42848f99842d8f3ec08b

@graphit0 graphit0 added the bug It's a bug label Nov 30, 2024
@personalizedrefrigerator
Copy link
Collaborator

Thank you for reporting this!

The issue seems to be related to commands/openItem.ts. When a link is invalid, an error dialog is only shown in some cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug
Projects
None yet
Development

No branches or pull requests

2 participants