From 04a75c2c1d7dfcbf15287051373e7249f2ee82ae Mon Sep 17 00:00:00 2001 From: Lautaro Dragan Date: Sat, 25 Jul 2020 00:14:25 -0300 Subject: [PATCH] my own readme --- CHALLENGE.md | 39 ++++++++++++++++++ README.md | 111 +++++++++++++++++++++++++++++++++------------------ 2 files changed, 111 insertions(+), 39 deletions(-) create mode 100644 CHALLENGE.md diff --git a/CHALLENGE.md b/CHALLENGE.md new file mode 100644 index 0000000..73ec8f9 --- /dev/null +++ b/CHALLENGE.md @@ -0,0 +1,39 @@ +# minesweeper-API +API test + +We ask that you complete the following challenge to evaluate your development skills. Please use the programming language and framework discussed during your interview to accomplish the following task. + +PLEASE DO NOT FORK THE REPOSITORY. WE NEED A PUBLIC REPOSITORY FOR THE REVIEW. + +## The Game +Develop the classic game of [Minesweeper](https://en.wikipedia.org/wiki/Minesweeper_(video_game)) + +## Show your work + +1. Create a Public repository ( please dont make a pull request, clone the private repository and create a new plublic one on your profile) +2. Commit each step of your process so we can follow your thought process. + +## What to build +The following is a list of items (prioritized from most important to least important) we wish to see: +* Design and implement a documented RESTful API for the game (think of a mobile app for your API) +* Implement an API client library for the API designed above. Ideally, in a different language, of your preference, to the one used for the API +* When a cell with no adjacent mines is revealed, all adjacent squares will be revealed (and repeat) +* Ability to 'flag' a cell with a question mark or red flag +* Detect when game is over +* Persistence +* Time tracking +* Ability to start a new game and preserve/resume the old ones +* Ability to select the game parameters: number of rows, columns, and mines +* Ability to support multiple users/accounts + +## Deliverables we expect: +* URL where the game can be accessed and played (use any platform of your preference: heroku.com, aws.amazon.com, etc) +* Code in a public Github repo +* README file with the decisions taken and important notes + +## Time Spent +You need to fully complete the challenge. We suggest not to spend more than 5 days total. Please make commits as often as possible so we can see the time you spent and please do not make one commit. We will evaluate the code and time spent. + +What we want to see is how well you handle yourself given the time you spend on the problem, how you think, and how you prioritize when time is sufficient to solve everything. + +Please email your solution as soon as you have completed the challenge or the time is up. diff --git a/README.md b/README.md index 73ec8f9..b62b707 100644 --- a/README.md +++ b/README.md @@ -1,39 +1,72 @@ -# minesweeper-API -API test - -We ask that you complete the following challenge to evaluate your development skills. Please use the programming language and framework discussed during your interview to accomplish the following task. - -PLEASE DO NOT FORK THE REPOSITORY. WE NEED A PUBLIC REPOSITORY FOR THE REVIEW. - -## The Game -Develop the classic game of [Minesweeper](https://en.wikipedia.org/wiki/Minesweeper_(video_game)) - -## Show your work - -1. Create a Public repository ( please dont make a pull request, clone the private repository and create a new plublic one on your profile) -2. Commit each step of your process so we can follow your thought process. - -## What to build -The following is a list of items (prioritized from most important to least important) we wish to see: -* Design and implement a documented RESTful API for the game (think of a mobile app for your API) -* Implement an API client library for the API designed above. Ideally, in a different language, of your preference, to the one used for the API -* When a cell with no adjacent mines is revealed, all adjacent squares will be revealed (and repeat) -* Ability to 'flag' a cell with a question mark or red flag -* Detect when game is over -* Persistence -* Time tracking -* Ability to start a new game and preserve/resume the old ones -* Ability to select the game parameters: number of rows, columns, and mines -* Ability to support multiple users/accounts - -## Deliverables we expect: -* URL where the game can be accessed and played (use any platform of your preference: heroku.com, aws.amazon.com, etc) -* Code in a public Github repo -* README file with the decisions taken and important notes - -## Time Spent -You need to fully complete the challenge. We suggest not to spend more than 5 days total. Please make commits as often as possible so we can see the time you spent and please do not make one commit. We will evaluate the code and time spent. - -What we want to see is how well you handle yourself given the time you spend on the problem, how you think, and how you prioritize when time is sufficient to solve everything. - -Please email your solution as soon as you have completed the challenge or the time is up. +# Minesweeper + +Solution to the Amazon challenge by Deviget. + +The challenge only requires an API, but I used to love minesweeper as a child, before I had internet, and this seems like a really fun challenge, so I decided to implement a frontend for it. + +I'm not spending a lot of time in code quality or aesthetics in the frontend though, as it's just an extra and I'm pretty short on time. I decided to go with next due to the simplicity of the framework, and avoid TypeScript because the complexity is going to stay pretty low and I'm going to be working on my own on it. 🤠 Yee-haw! + +## Plan + +1. Implement everything in the frontend +1. Add backend +1. Move game logic to backend. Frontend will then be "blind" to the state of unknown cells, no Chrome Inspector cheating! +1. Add auth +1. Make client library. Using TypeScript, ideally. +1. Refactor frontend to use client library. + +## Challenges + +Minesweeper is a game with pretty simple mechanics. If you click on a mine, it's game over. If you find all mines, it's a win. + +### Challenge 1: Recursion + +The only challenging mechanic is triggered when you click on an empty cell: all surrounding empty cells must be cleared, and so on. This is simple recursion, the same used by the Flood Fill of MS Paint and other simple paint programs. Luckily I've already implemented this in the past while developing game engines — flood fill is an useful tool when editting 2D top-down RPG maps. The hidden challenge in the recursion is an easily reachable stack overflow, which can be avoided controlling the max depth of recursive calls, storing temporary state in a list. There are probably more efficient solutions to the problem, but this one works pretty well. If the board is small the stack overflow may not even be a problem, though. + +Doing this recursion server-side at scale would probably be a huge challenge, which would require research and experimentation. But we're not going for scalability right now. + +### Challenge 2: Persistence + +The other challenge is persisting the state of the game. The simplest approach is just storing the entire matrix in MongoDB. This is the approach I'm gonna follow in the challenge. + +A simple optimization on top of that would be serializing the matrix, storing 1 byte indicating the width, 1 for the height, and then 1 byte for each cell. You could even make it smaller by storing cell values in a nibble instead of a byte, using bit-wise operators, since there are only so few possible values for each cell. But this is an optimization, and we don't care about optimizations in code challenges or PoCs. We can literally run the most primitive implementation in the free tiers of Heroku, Mongo Atlas and Netlify / Vercel, and still scale up to tens or maybe even hundreds of concurrent users. + +### Challenge 3: Auth + +There are many ways to do auth these days. I'd love to implement Auth0, which is pretty simple and very powerful, if time allows. Otherwise, I may just go with email+password and a JWT. + +## API + +We are going to need a couple of endpoints. + +### GET /games + +401 if auth not present or invalid. + +200 + array of games "owned" by authenticated user otherwise. Since it's going to be a list of all games, avoid returning game cell state, which is the heaviest property. This is intended for rendering in a list of past and ongoing games. + +### GET /games/:id + +401 if auth not present or invalid. +403 if game not owned by authenticated user. +200 + game with cell data otherwise. + +### POST /games + +This is our "new game" endpoint. + +The client is required to create and provide the ID of the game. A UUIDv4 will be used for this. + +400, 403 or 422 (Can't make my mind up) if a game with the provided `id` already exists. +201 otherwise. + +#### Small Note on Client-Generated IDs + +The industry standard up until not so long ago was for DB engines to create ids, so it's pretty common for people to feel alienated by client-generated ids. + +Generating IDs on the client-side is a standard practice when following the CQRS / event sourcing philosophy. Mark Seemann wrote [a nice piece on this subject](https://blog.ploeh.dk/2014/08/11/cqs-versus-server-generated-ids/). + +UUID collisions are possible, albeit unlikely. Astronomically unlikely, in theory. Here's [a cool read about generating UUIDs at scale, client side](https://medium.com/teads-engineering/generating-uuids-at-scale-on-the-web-2877f529d2a2). + + +