Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce time events in DHC.ETS.Combined.ChillerOnly (and related models) #4058

Closed
mwetter opened this issue Nov 23, 2024 · 0 comments · Fixed by #4059
Closed

Reduce time events in DHC.ETS.Combined.ChillerOnly (and related models) #4058

mwetter opened this issue Nov 23, 2024 · 0 comments · Fixed by #4059
Assignees
@mwetter

Comments

@mwetter
Copy link
Member

mwetter commented Nov 23, 2024

Models such as Buildings.DHC.ETS.Combined.Examples.ChillerOnly sample every 60 seconds to keep a boolean signal constant for a while and through that avoid short-cycling.
This sampling is done with a FirstOrderHold. If it were done with a TrueFalseHold, then the number of time events would be significantly reduced.

For example, for Buildings.DHC.ETS.Combined.Examples.ChillerOnly, the current implementation has in Dymola 8000 time events and takes 1.4 seconds to simulate, and with the proposed implementation, it has 150 time events and takes 0.6 seconds to simulate.
@mwetter mwetter self-assigned this Nov 23, 2024
mwetter added a commit that referenced this issue Nov 23, 2024
@mwetter
Reduced number of time events for ETS model
73372f2 
For #4058
mwetter added a commit that referenced this issue Nov 23, 2024
@mwetter
Reduced number of time events for ETS model
15c1388 
For #4058
@mwetter mwetter mentioned this issue Nov 23, 2024
Merged
mwetter added a commit that referenced this issue Nov 25, 2024
@mwetter @AntoineGautier
Remove time events in ETS model with heat recovery chiller (#4059)
32156a1 
* Reduced number of time events for ETS model

For #4058

* Added pre block to break algebraic loop during initialization

This is needed for OpenModelica

* Removed duplicate connection

* Increase minimum cycle time

* Update results

---------

Co-authored-by: Antoine Gautier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwetter mwetter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove time events in ETS model with heat recovery chiller lbl-srg/modelica-buildings
1 participant
@mwetter