Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove time events in ETS model with heat recovery chiller #4059

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Remove time events in ETS model with heat recovery chiller #4059

wants to merge 4 commits into from
+205 −156

Conversation

mwetter
Copy link
Member

@mwetter mwetter commented Nov 23, 2024

This closes #4058
It also removes a duplicate signal connection.

@mwetter mwetter added this to the Release 12.0.0 milestone Nov 23, 2024
@mwetter mwetter added the non-backward compatible Non-backward compatible changes label Nov 23, 2024
@mwetter
Copy link
Member Author

mwetter commented Nov 23, 2024

@AntoineGautier : Can you please have a brief look into this refactoring. It replaces a FirstOrderHold with 60 s sampling time with a TrueFalseHold and a Pre at its input. The TrueFalseHold avoids the frequent time events and the Pre is needed for OpenModelica to avoid a nonlinear equation in a when construct during the initialization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AntoineGautier AntoineGautier

Labels
non-backward compatible Non-backward compatible changes
Projects
None yet
Milestone
Release 12.0.0
Development

Successfully merging this pull request may close these issues.

Reduce time events in DHC.ETS.Combined.ChillerOnly (and related models)
2 participants
@mwetter @AntoineGautier