Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix updating image src data #259

Open
shlag3n opened this issue Jun 8, 2023 · 0 comments
Open

Fix updating image src data #259

shlag3n opened this issue Jun 8, 2023 · 0 comments
Assignees
@edgarf
Labels
bug Something isn't working

Comments

@shlag3n
Copy link
Collaborator

shlag3n commented Jun 8, 2023

Fix fix_inline_img method as it'll set src empty if no matches. e.g by using gsub instead of gsub!

Note:
Also it'd be great to understand if we need that method or not and if we do add some explanation why.
@shlag3n shlag3n added the bug Something isn't working label Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edgarf edgarf

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edgarf @shlag3n