Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metal build #513

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix metal build #513

wants to merge 1 commit into from

Conversation

stduhpf
Copy link
Contributor

@stduhpf stduhpf commented Dec 5, 2024

Some ggml API changes were causing metal builds to fail.

Fixes #512

@@ -161,7 +161,7 @@ class StableDiffusionGGML {
#endif
#ifdef SD_USE_METAL
LOG_DEBUG("Using Metal backend");
ggml_backend_metal_log_set_callback(ggml_log_callback_default, nullptr);
ggml_log_set(ggml_log_callback_default, nullptr);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be inside of the ifdef.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're probably right. I just replaced 1 to 1 to make sure I'm not breaking other backends as a side effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failing with Metal
2 participants