Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pretty_progress to also display step 0 #515

Open
dsignarius opened this issue Dec 8, 2024 · 0 comments
Open

Change pretty_progress to also display step 0 #515

dsignarius opened this issue Dec 8, 2024 · 0 comments

Comments

@dsignarius
Copy link

pretty_progress in util.cpp is called from stablediffusion.cpp to display the progress of steps along the process.

in stablediffusion.cpp it is called with a value of step=0, this is to signal that the first step has started and computation has started. then with the later steps the progress is displayed.
Without this then it is not displayed that the generation process has started and step 0 is in progress. On slower machines, those using cpu only or igpu, then this can lead to some confusion as to how far the whole process has gone.

pretty_progress in util.cpp contains the following lines:
if (step == 0) {
return;
}

yet, it is called explicitly with a value of 0, as described above.

suggest removing or commenting out the return above..
then the start of processing, when the first step commences will be displayed properly and the user will know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant