Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about typescript support? #11

Open
maykon-oliveira opened this issue Jan 16, 2021 · 4 comments
Open

How about typescript support? #11

maykon-oliveira opened this issue Jan 16, 2021 · 4 comments

Comments

@maykon-oliveira
Copy link

I think it should be a great feature to library.

@ayrtonvwf
Copy link

I can create a PR for that, would that be ok @zarathustra323 @solocommand?

@solocommand
Copy link
Member

I can create a PR for that, would that be ok @zarathustra323 @solocommand?

@ayrtonvwf Not opposed to this, but what would that look like structurally? So long as it is additive and won't impact anyone not using typescript I think that would probably be welcome.

@ayrtonvwf
Copy link

@solocommand I would create some definition files and include a reference to it on the package.json, with no impact to anyone not using typescript. Glad to hear from you, I'll be submitting a PR in the next few days. Thank you!

@jjdechavez
Copy link

Any update for this issue? I hope I can use this lib on TS project soon as possible. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants