Ping/Pong in WebSockets are not plain text

[nicola]

The ping in the websocket is a special character 0x9/0x10, while in the implementation I saw "ping"/"pong"

gold/websocket.go

Line 56 in 5534f4a

case "ping":

Maybe that is already implemented in "golang.org/x/net/websocket" or maybe this is how it is implemented, ping me back

[presbrey]

This functionality is a application-level NOOP I created during browser JS integration/development.

[nicola]

Perfect!
Do you think we should take it out? Should we implement ping/pong as 0x9/0x10?

(ps: nice to e-meet you @presbrey)

[presbrey]

If we are looking to polish/clean things up, there are much lower hanging fruit imho :)

The x/websocket library handles the 0x9/0x10 at a lower protocol level that is hard to see when you are developing in the browser, just as TCP keepalives exist further below that.

Why would remove it? Is there a new standard for linked data updates over websockets? Does it conflict with a new protocol you want to try?

[nicola]

Oh no no, I just saw it as something "extra" and not needed (and I thought we were trying to achieve what x/websocket does - and I didnt know it did)