URL handling not working with lita templating functionality

[dieterdemeyer]

Hello,

I'm trying out the lita templating functionality using the slack adapter but can't seem to get the URL handling to work.
I'm using the following code in my .erb file:

*GitHub Org Pull Requests:*
<% @github_open_issues.each do |repo_name, issues| %>
<% issues.each do |issue| %>
• <%= repo_name %>: <<%= issue.html_url %>|pull request #<%= issue.number %>> - <%= issue.title %> - by <<%= issue.user.html_url %>|<%= issue.user.login %>>
<% end %>
<% end %>

The output now is:

• puppet-alternatives: <https://github.com/cegeka/puppet-alternatives/pull/1|pull request #1> - fix: insync function comparing current and should items - by <https://github.com/vladnazarenko|vladnazarenko>

But I would like to see the following:

• puppet-alternatives: pull request #1 - fix: insync function comparing current and should items - by vladnazarenko

Any suggestions on what I'm doing wrong ?
I think I'm using the correct syntax for links in Slack but any help would be appreciated..

[jimmycuadra]

lita-slack 1.5 was just released with new logic to remove the special formatting the Slack applies to incoming messages. Try it again with 1.5 and see if it works how you'd expect it to!

[pseudomuto]

This seems like it's still a problem in 1.5. @dieterdemeyer did you ever find a solution for this?

[freibuis]

@pseudomuto I tried the code example listed and it works ok..

do you have some examples that I can look at?

[pseudomuto]

For sure. I was trying get github deployment information and render a few links in there. Here's the snippet that wasn't working for me (just renders the supplied text inside < > rather than linking:

*Latest deploys for <%= @repo.full_name %>*
<% @deploys.each do |deploy| %>
> <%= deploy.at %> - *<%= deploy.user %>* <<%= deploy.url %>|deployed> <%= @repo.repo_name %>/<%= @repo.full_name %> (<%= "<#{@repo.url_for_sha(deploy.sha)}|#{@repo.shorten_sha(deploy.sha)}>" %>) to *<%= deploy.environment %>*
<% end %>

[ewr]

This is an issue with the Slack RTM message handling. See slackhq/slack-api-docs#32.

The workaround is to use the API chat.postMessage endpoint for complex messages.

This lita-slack fork (not mine, but probably one I'll grab to address this issue for the moment) implements that by assuming that non-strings sent to send_messages are complex messages, and pointing them to the API: jaisonerick@fc4138c

That gives you support for attachments, but doesn't make a happy path for inline formatting. For that you would need to do something funkier, like a regex for format-looking bits in the message string.

[dieterdemeyer]

@pseudomuto I hadn't gotten around to testing this yet due to other stuff..
I'll see if I can test this again in the near future.

[pseudomuto]

@dieterdemeyer cool...thanks man! In the mean time, I'll monkey patch with@ewr's diff from #49 and see if that resolves it.

[paquettej]

+1 Any eta on a fix?

[jimmycuadra]

Anyone following this issue may be interested in #68—I think it will address this.

[jimmycuadra]

Update: the PR to follow is now #76.