Fix allow_other vulnerability preventing google-batch submissions (ne…

…xtflow-io#4332)
llewellyn-sl · Sep 21, 2023 · 9b3741e · 9b3741e
1 parent 66b2d2d
commit 9b3741e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/plugins/nf-google/src/main/nextflow/cloud/google/batch/GoogleBatchScriptLauncher.groovy b/plugins/nf-google/src/main/nextflow/cloud/google/batch/GoogleBatchScriptLauncher.groovy
@@ -134,7 +134,7 @@ class GoogleBatchScriptLauncher extends BashWrapperBuilder implements GoogleBatc
                             .setRemotePath(it)
                     )
                     .setMountPath( "${MOUNT_ROOT}/${it}".toString() )
-                    .addAllMountOptions( ['-o rw,allow_other', '-implicit-dirs'] )
+                    .addAllMountOptions( ['-o rw', '-implicit-dirs'] )
                     .build()
             )
         }

diff --git a/plugins/nf-google/src/test/nextflow/cloud/google/batch/GoogleBatchScriptLauncherTest.groovy b/plugins/nf-google/src/test/nextflow/cloud/google/batch/GoogleBatchScriptLauncherTest.groovy
@@ -71,10 +71,10 @@ class GoogleBatchScriptLauncherTest extends Specification{
         volumes.size() == 2
         volumes[0].getGcs().getRemotePath() == 'alpha'
         volumes[0].getMountPath() == '/mnt/disks/alpha'
-        volumes[0].getMountOptionsList() == ['-o rw,allow_other', '-implicit-dirs']
+        volumes[0].getMountOptionsList() == ['-o rw', '-implicit-dirs']
         volumes[1].getGcs().getRemotePath() == 'omega'
         volumes[1].getMountPath() == '/mnt/disks/omega'
-        volumes[1].getMountOptionsList() == ['-o rw,allow_other', '-implicit-dirs']
+        volumes[1].getMountOptionsList() == ['-o rw', '-implicit-dirs']
     }
 
 }