-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use alias
in LLVM::GlobalOp
lowering once LLVM IR Dialect has it
#1065
Comments
Shouldn't we file this upstream? |
alias
attribute on LLVM::GlobalOp
alias
in LLVM::GlobalOp
lowering once LLVM IR Dialect has it
Mostly worried about tracking what we need to do in CIR once this lands, retitle to be more clear. We should file this upstream against MLIR for sure, but since @thevinster might grab this I'll let him decide if he wants to produce a PR or an issue (or both). |
Even harder than what it seems, I also hit #1083 while trying to fix this. Once we get unblocked, we need to look at |
Report MLIR upstream in llvm/llvm-project#115390 |
While working at this, I noticed that LLVM IR dialect GlobalOp does not yet support
alias
, so we cannot yet lower this information down. Let me file another issue for that.For now, I'm going to emit a global but not yet set the alias, won't be much better than what we currently have but it's a first step - later on we can just set the alias when MLIR support comes.
Originally posted by @bcardosolopes in #1048 (comment)
The text was updated successfully, but these errors were encountered: