Add bazel configs for some C APIs and pybinds #3879
+95
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sjain-stanford are you the right person to review this? this is a follow up to our discord conversation. |
sjain-stanford
requested changes
Nov 18, 2024
There was a problem hiding this comment.
Thanks @tkocmathla . As it stands, there is no way to test these python interfaces. Can you please add some python test targets that depend on these (and hence are tested in CI)? You probably need a hermetic python interpreter setup in bazel as well.
| @@ -923,3 +924,96 @@ cc_binary( | |||
| "@llvm-project//mlir:MlirOptLib", | |||
| ], | |||
| ) | |||
|
|
|||
| # C API bindings | |||
There was a problem hiding this comment.
For isolation and ease of maintenance, I'd suggest creating a separate python/BUILD.bazel to host everything below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves bazel support by adding rules for building the following:
torch-mlir-c/Registration.htorch-mlir-c/Dialects.htorchdialecttorchopsCloses #3787.