Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update curve dependency #4

Open
nim65s opened this issue Mar 31, 2020 · 2 comments
Open

Update curve dependency #4

nim65s opened this issue Mar 31, 2020 · 2 comments

Comments

@nim65s
Copy link
Contributor

nim65s commented Mar 31, 2020

Hi,

This package still depends on the old parametric-curves library:

ADD_REQUIRED_DEPENDENCY("parametric-curves")

This should be updated to https://github.com/loco-3d/curves

@pFernbach
Copy link
Member

pFernbach commented Mar 31, 2020

Hi, unfortunately Curves do not have all the features required for an easy refactoring of sot-balance-balance yet. See https://gepgitlab.laas.fr/loco-3d/curves/issues?milestone_title=sot-talos-balance+requirements

Most of this issues seems quite easy to solve, but there is some discussion on the design and expected behavior that never converged. I will probably take care of the "easy" issues, but not before several weeks.

@olivier-stasse
Copy link
Collaborator

@nim65s Everything depends on one object called nd-trajectory-generator.cpp.
We had a request from @andreadelprete to move this object to sot-core as it used by sot-torque-control.
stack-of-tasks/sot-torque-control#70
From a practical viewpoint I do not see why we could not switch in this repo to the new library.
For now this is not a blocking issue, but indeed we should get rid of parametric-curves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants