Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer#copy instead of buffer#slice #2

Open
themasch opened this issue Mar 1, 2014 · 0 comments
Open

buffer#copy instead of buffer#slice #2

themasch opened this issue Mar 1, 2014 · 0 comments

Comments

@themasch
Copy link
Member

themasch commented Mar 1, 2014

There are some regions where the parser slices parts out of the input buffer and returns them as part of the result.
We should use copy() here because slice() references the same as the input buffer. This means that the input buffer can't be freed or reused which leads to memory leaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant