Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

Support nested transactions using SAVEPOINT #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jud
Copy link
Collaborator

@Jud Jud commented Apr 23, 2015

The base branch for #111 was deleted, so I'm opening a new PR with a new base branch.

(Fixes #56)

@Jud Jud added the Feature label Apr 23, 2015
@Jud Jud added this to the 1.4.0 milestone Apr 23, 2015
@Jud Jud mentioned this pull request Apr 23, 2015
@Jud Jud changed the title Support nested transactions using SAVEPOINT (Fixes #56) Support nested transactions using SAVEPOINT Apr 23, 2015
@bjornpost
Copy link
Collaborator

That's quite a PR, nice work! I'll have a look at this once we have 1.3.2 released. Would you mind writing some documentation for this as well? IIRC transactions are currently not explained at all in the docs.

@Jud Jud force-pushed the adding-savepoints branch from 6b60a4e to e547534 Compare April 25, 2015 22:33
@bjornpost
Copy link
Collaborator

Code LGTM. An example of how to use in the docs would be great. While you're at it, maybe we can also add an extra example of how Events work?

@bjornpost
Copy link
Collaborator

@Jud ping for docs :-)

@bjornpost bjornpost modified the milestones: 1.4.0, 2.0.0 May 7, 2016
@Jud
Copy link
Collaborator Author

Jud commented Jan 5, 2018

@bjornpost re: the docs, they are relatively unchanged. IMO this just makes the existing transaction code work like a casual observer would expect them to. I'll open another issue for cleaning up event docs.

Edit: btw, we've been running this code in production since ~2015. May be some corner cases we're not running into, but generally works as expected.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support nested transactions using SAVEPOINT
2 participants