Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate the approaches between BancorFormula and PriceCurves #1

Open
lsaether opened this issue Oct 14, 2018 · 0 comments
Open

Evaluate the approaches between BancorFormula and PriceCurves #1

lsaether opened this issue Oct 14, 2018 · 0 comments

Comments

@lsaether
Copy link
Owner

Along my journey of scouring the existing code and documentation surrounding curve bonded tokens I've noticed two differing approaches:

  1. The use of Integral formulas which will calculate the price give the inputs of _totalSupply, _poolBalance, and _amount. This initially cause me much trouble as I was accepting the value returned from these curves as the return amounts. After some testing I found that they were the integrals for the prices instead, which IMO is less than ideal.

  2. The second approach I'm still wrapping my head around. The use of the BancorFormula seems to make it so that the smart contract can synthesize the correct amount of tokens given the input of _amount. I'm skeptical because this is much more complex of an approach and uses Bancor's "proprietary" smart contract. It needs some closer inspection and research. Ultimately I think the opportunity is bright along these lines by creating variation of the BancorFormula, but this is just late night conjecture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant