Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7? #169

Closed
phanan opened this issue Sep 17, 2018 · 3 comments
Closed

PHP 7? #169

phanan opened this issue Sep 17, 2018 · 3 comments

Comments

@phanan
Copy link
Collaborator

phanan commented Sep 17, 2018

The support for PHP 5.6 (and even 7.0) is ending by the end of this year. Should we make the lib PHP 7.1? Happy to work on it if positive.

@Kaishiyoku
Copy link

So...what's the status? PHP 5.6 is now officially unsupported. It would be great to stick with 7.1

@lstrojny
Copy link
Owner

lstrojny commented Feb 8, 2019

My thought was to require PHP 7.x for functional 2 where I plan to fix various issues. See #141 for details.

@lstrojny lstrojny closed this as completed Feb 8, 2019
@shainegordon
Copy link

We use this library successfully on PHP 7.1 based composer projects.

However, since upgrading all our projects to PHP 7.3, while still wanting to this excellent library, we have had to fork the source for 1.9.0 so that we can comment out define('Functional\\…', …()); in PartialAny.php to avoid

[ErrorException]                                                   
  Constants may only evaluate to scalar values, arrays or resources

on composer's dumpautoload process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants